netdev - Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXgKbHG5dL77d=yqarn_xJapVKv3z10Kzsn34vkKWUoTA@mail.gmail.com>
Date:   Wed, 12 Jul 2017 10:45:52 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     张军伟(基础平台部) 
        <zhangjunweimartin@...ichuxing.com>
Cc:     Neil Horman <nhorman@...driver.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        martinbj2008 <martinbj2008@...il.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH v1 net-next 1/5] drop_monitor: import netnamespace framework

On Wed, Jul 12, 2017 at 10:08 AM, 张军伟(基础平台部)
<zhangjunweimartin@...ichuxing.com> wrote:
> about skb->sk
> it is used as supplementary when skb->dev is empty，such as netlink message。
>
> +       if (skb->dev)
> +               net = dev_net(skb->dev);
> +       else if (skb->sk)
> +               net = sock_net(skb->sk);
> +       else
> +               return;

Check udp_set_dev_scratch().

Again, as Neil mentioned, the idea is arguable, it is actually harder to trace
skb's with your patch when they across netns'es.