netdev - Re: [PATCH net] sfc: don't read beyond unicast address list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170712.144222.1359946377809355868.davem@davemloft.net>
Date:   Wed, 12 Jul 2017 14:42:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bkenward@...arflare.com
Cc:     netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: don't read beyond unicast address list

From: Bert Kenward <bkenward@...arflare.com>
Date: Wed, 12 Jul 2017 17:19:41 +0100

> If we have more than 32 unicast MAC addresses assigned to an interface
> we will read beyond the end of the address table in the driver when
> adding filters. The next 256 entries store multicast addresses, so we
> will end up attempting to insert duplicate filters, which is mostly
> harmless. If we add more than 288 unicast addresses we will then read
> past the multicast address table, which is likely to be more exciting.
> 
> Fixes: 12fb0da45c9a ("sfc: clean fallbacks between promisc/normal in efx_ef10_filter_sync_rx_mode")
> Signed-off-by: Bert Kenward <bkenward@...arflare.com>

Applied and queued up for -stable, thanks.