netdev - Re: [PATCH net] nfp: freeing the wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170712005441.5f9169d0@cakuba.netronome.com>
Date:   Wed, 12 Jul 2017 00:54:41 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>,
        Simon Horman <simon.horman@...ronome.com>,
        oss-drivers@...ronome.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] nfp: freeing the wrong variable

On Wed, 12 Jul 2017 10:42:06 +0300, Dan Carpenter wrote:
> We accidentally free a NULL pointer and leak the pointer we want to
> free.  Also you can tell from the label name what was intended.  :)
> 
> Fixes: abfcdc1de9bf ("nfp: add a stats handler for flower offloads")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Thanks!