netdev - Re: [PATCH 1/1] mlx4_en: remove unnecessary returned value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170712083647.GB2866@yuvallap>
Date:   Wed, 12 Jul 2017 11:36:48 +0300
From:   Yuval Shaia <yuval.shaia@...cle.com>
To:     Zhu Yanjun <yanjun.zhu@...cle.com>
Cc:     tariqt@...lanox.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, leon@...nel.org
Subject: Re: [PATCH 1/1] mlx4_en: remove unnecessary returned value check

On Wed, Jul 12, 2017 at 02:44:33AM -0400, Zhu Yanjun wrote:
> The function __mlx4_zone_remove_one_entry always returns zero. So
> it is not necessary to check it.
> 
> Cc: Joe Jin <joe.jin@...cle.com>
> Cc: Junxiao Bi <junxiao.bi@...cle.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/alloc.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/alloc.c b/drivers/net/ethernet/mellanox/mlx4/alloc.c
> index 249a458..bfb185d 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/alloc.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/alloc.c
> @@ -283,7 +283,7 @@ int mlx4_zone_add_one(struct mlx4_zone_allocator *zone_alloc,
>  }
>  
>  /* Should be called under a lock */
> -static int __mlx4_zone_remove_one_entry(struct mlx4_zone_entry *entry)
> +static void __mlx4_zone_remove_one_entry(struct mlx4_zone_entry *entry)
>  {
>  	struct mlx4_zone_allocator *zone_alloc = entry->allocator;
>  
> @@ -315,8 +315,6 @@ static int __mlx4_zone_remove_one_entry(struct mlx4_zone_entry *entry)
>  		}
>  		zone_alloc->mask = mask;
>  	}
> -
> -	return 0;
>  }
>  
>  void mlx4_zone_allocator_destroy(struct mlx4_zone_allocator *zone_alloc)
> @@ -468,7 +466,8 @@ int mlx4_zone_remove_one(struct mlx4_zone_allocator *zones, u32 uid)
>  		goto out;
>  	}
>  
> -	res = __mlx4_zone_remove_one_entry(zone);
> +	__mlx4_zone_remove_one_entry(zone);
> +	res = 0;

Will look better if initialization will move to variable declaration.

Besides this minor thing - lgtm.

Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>

>  
>  out:
>  	spin_unlock(&zones->lock);
> -- 
> 2.7.4
>