lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Jul 2017 16:50:50 +0200 From: Andrew Lunn <andrew@...n.ch> To: sean.wang@...iatek.com Cc: john@...ozen.org, davem@...emloft.net, nbd@...nwrt.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH net-next 2/4] net-next: mediatek: add platform data to adapt into various hardware > +static int mtk_clk_enable(struct mtk_eth *eth) > +{ > + int clk, ret; > + > + for (clk = 0; clk < MTK_CLK_MAX ; clk++) { > + if (eth->clks[clk]) { > + ret = clk_prepare_enable(eth->clks[clk]); > + if (ret) > + goto err_disable_clks; > + } > + } > + > + return 0; > + > +err_disable_clks: > + while (--clk >= 0) { > + if (eth->clks[clk]) > + clk_disable_unprepare(eth->clks[clk]); > + } > + > + return ret; > +} > + > static int mtk_hw_init(struct mtk_eth *eth) > { > int i, val; > @@ -1847,10 +1881,8 @@ static int mtk_hw_init(struct mtk_eth *eth) > pm_runtime_enable(eth->dev); > pm_runtime_get_sync(eth->dev); > > - clk_prepare_enable(eth->clks[MTK_CLK_ETHIF]); > - clk_prepare_enable(eth->clks[MTK_CLK_ESW]); > - clk_prepare_enable(eth->clks[MTK_CLK_GP1]); > - clk_prepare_enable(eth->clks[MTK_CLK_GP2]); > + mtk_clk_enable(eth); > + mtk_clk_enable() returns an error code. It is probably a good idea to use it, especially if it could be EPRODE_DEFER. Andrew
Powered by blists - more mailing lists