netdev - Re: [PATCH net] net: set fib rule refcount after malloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170713.134335.1544432096954681162.davem@davemloft.net>
Date:   Thu, 13 Jul 2017 13:43:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     edumazet@...gle.com, idosch@...lanox.com, jiri@...lanox.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: set fib rule refcount after malloc

From: David Ahern <dsahern@...il.com>
Date: Thu, 13 Jul 2017 13:36:40 -0700

> The configure callback of fib_rules_ops can change the refcnt of a
> fib rule. For instance, mlxsw takes a refcnt when adding the processing
> of the rule to a work queue. Thus the rule refcnt can not be reset to
> to 1 afterwards. Move the refcnt setting to after the allocation.
> 
> Fixes: 5361e209dd30 ("net: avoid one splat in fib_nl_delrule()")
> Signed-off-by: David Ahern <dsahern@...il.com>

Can someone keep a scoreboard of how many bugs and arbitrary
unnecessary changes get introduced because of this new refcount_t
business rather than get fixed?

I'd really like to see how that pans out over the long term especially
with all of the backporting pain this facility is going to cause.

Anyways, David I will apply this, thanks.