netdev - Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170714013435.GA9065@lunn.ch>
Date:   Fri, 14 Jul 2017 03:34:35 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Moritz Fischer <moritz.fischer@...us.com>
Cc:     Moritz Fischer <mdf@...nel.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, mark.rutland@....com, robh+dt@...nel.org
Subject: Re: [PATCH 2/2] net: ethernet: nixge: Add support for National
 Instruments XGE netdev

> > > +	/* not sure if this is the correct way of dealing with this ... */
> > > +	ndev->phydev->supported &= ~(SUPPORTED_Autoneg);
> > > +	ndev->phydev->advertising = ndev->phydev->supported;
> > > +	ndev->phydev->autoneg = AUTONEG_DISABLE;
> > 
> > What are you trying to achieve?
> 
> Basically can't do Autoneg, I'll need to take a closer look.

Hi Moritz

What i actually think you mean, is it can only do 1Gbps. So you could
autoneg, but only advertise 1Gbps. Look at masking out
PHY_10BT_FEATURES and PHY_100BT_FEATURES.

Take a look at:

http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/renesas/ravb_main.c#L1045

It might actually make sense to add a phy_set_min_speed(), a mirror to
phy_set_max_speed().

	Andrew