netdev - Re: [net-next PATCH 09/12] bpf: add bpf_redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <596CF0EA.7090100@gmail.com>
Date:   Mon, 17 Jul 2017 10:16:26 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Alexei Starovoitov <ast@...com>, davem@...emloft.net
CC:     daniel@...earbox.net, netdev@...r.kernel.org, brouer@...hat.com,
        andy@...yhouse.net
Subject: Re: [net-next PATCH 09/12] bpf: add bpf_redirect_map helper routine

On 07/17/2017 10:00 AM, Alexei Starovoitov wrote:
> On 7/17/17 9:29 AM, John Fastabend wrote:
>> + * int bpf_redirect_map(key, map, flags)
>> + *     redirect to endpoint in map
>> + *     @key: index in map to lookup
>> + *     @map: fd of map to do lookup in
>> + *     @flags: --
> 
> could you please adjust the comment describing return value
> and also fix the comment next to bpf_redirect()
> since that function got reused between tc and xdp.

Looks like Dave pulled it in so I'll roll a patch on top of that
with the comment description fix. Thanks.

> 
> Great stuff!
> looking forward to support in other drivers.
>