netdev - Re: [ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5A8CA8BA-DB4C-4CFB-B772-C0BCAEBBFDDA@gmail.com>
Date:   Tue, 18 Jul 2017 13:39:36 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     Pravin Shelar <pshelar@....org>
Cc:     ovs dev <dev@...nvswitch.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS
 flow_stats.


> On Jul 18, 2017, at 11:14 AM, Pravin Shelar <pshelar@....org> wrote:
> 
>> 
>> This patch adds cpumask struct, the cpu_used_mask stores the cpu_id
>> that the flow used. And we only check the flow_stats on the cpu we
>> used, and it is unncessary to check all possible cpu when getting,
>> cleaning, and updating the flow_stats. Adding the cpu_used_mask to
>> sw_flow struct does’t increase the cacheline number.
>> 
>> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> Patch looks good to me. I have one comment.

Thanks. I will sent v2 and add “Acked-by”.