netdev - Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f984a9c-e6d3-fd0a-6719-fa9032d43d1d@cogentembedded.com>
Date:   Tue, 18 Jul 2017 12:56:27 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Fabio Estevam <festevam@...il.com>, davem@...emloft.net
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

Hello!

On 7/18/2017 12:09 AM, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@....com>
> 
> The gpiod API checks for NULL descriptors, so there is no need to
> duplicate the check in the driver.

    Won't this result in kernel WARNING when GPIO is disabled?

> Signed-off-by: Fabio Estevam <fabio.estevam@....com>
[...]

MBR, Sergei