netdev - [PATCH ethtool net] ethtool: fix the rx vs tx mixup in set channel message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 19:02:32 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     linville@...driver.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: [PATCH ethtool net] ethtool: fix the rx vs tx mixup in set channel message

When set channels (ethtool -L) doesn't modify any settings
a message is printed which contains the current parameters:

# ethtool -L em1
no channel parameters changed, aborting
current values: tx 4 rx 1 other 0 combined 0

or

# ethtool -L em1 rx 4
rx unmodified, ignoring
no channel parameters changed, aborting
current values: tx 4 rx 1 other 0 combined 0

In this message, however, rx and tx values are swapped,
which can be confirmed running get:

# ethtool -l em1
...
Current hardware settings:
RX:		 4
TX:		 1
Other:		 0
Combined:	 0

Reorder the rx and tx names in the string thus keeping the order
in line with ethtool -l.

Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
---
 ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ethtool.c b/ethtool.c
index ad18704e7c5f..4fd340540303 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -1995,7 +1995,7 @@ static int do_schannels(struct cmd_context *ctx)
 
 	if (!changed) {
 		fprintf(stderr, "no channel parameters changed, aborting\n");
-		fprintf(stderr, "current values: tx %u rx %u other %u"
+		fprintf(stderr, "current values: rx %u tx %u other %u"
 			" combined %u\n", echannels.rx_count,
 			echannels.tx_count, echannels.other_count,
 			echannels.combined_count);
-- 
2.11.0