netdev - Re: [Resend, PATCH v1] ISDN: eicon: switch to use native bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170719.162539.1609821913713350183.davem@davemloft.net>
Date:   Wed, 19 Jul 2017 16:25:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andriy.shevchenko@...ux.intel.com
Cc:     mac@...ware.de, isdn@...ux-pingi.de, netdev@...r.kernel.org
Subject: Re: [Resend, PATCH v1] ISDN: eicon: switch to use native bitmaps

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Tue, 18 Jul 2017 18:49:26 +0300

> Two arrays are clearly bit maps, so, make that explicit by converting to
> bitmap API and remove custom helpers.
> 
> Note sig_ind() uses out of boundary bit to (looks like) protect against
> potential bitmap_empty() checks for the same bitmap.
> 
> This patch removes that since:
> 1) that didn't guarantee atomicity anyway;
> 2) the first operation inside the for-loop is set bit in the bitmap
>    (which effectively makes it non-empty);
> 3) group_optimization() doesn't utilize possible emptiness of the bitmap
>    in question.
> 
> Thus, if there is a protection needed it should be implemented properly.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied, thanks.