lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jul 2017 09:59:52 +0300 From: Luca Coelho <luca@...lho.fi> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, johannes.berg@...el.com, emmanuel.grumbach@...el.com, linuxwifi@...el.com, kvalo@...eaurora.org, sara.sharon@...el.com Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH v2] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()' On Fri, 2017-07-14 at 12:06 +0200, Christophe JAILLET wrote: > We should free 'wgds.pointer' here as done a few lines above in another > error handling path. > It was allocated within 'acpi_evaluate_object()'. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- > v2: rebase after 7fe90e0e3d60 ("iwlwifi: mvm: refactor geo init") Thanks, Christophe! I've pushed this to our internal tree and it will eventually reach the mainline via our normal process. > Moreovern a comment in '/drivers/acpi/acpica/utalloc.c' states that: > /* [...] Note: The caller should use acpi_os_free to free this > * buffer created via ACPI_ALLOCATE_BUFFER. > */ > > So, at the end of this function: > out_free: > kfree(wgds.pointer); > should maybe be: > out_free: > acpi_os_free(wgds.pointer); > > If correct, several places should be fixed accordingly. Thanks for pointing out! I'm about to do some refactoring in this code and I'll make sure I check the proper way to free the acpi buffer when doing so. -- Cheers, Luca.
Powered by blists - more mailing lists