netdev - Re: [PATCH net-next 07/11] net: dsa: Remove support for bypass bridge port attributes/vlan set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07d8159d-d7ab-eac2-0519-b1ce3c8e18c8@mellanox.com>
Date:   Wed, 19 Jul 2017 14:53:44 +0300
From:   Arkadi Sharshevsky <arkadis@...lanox.com>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...nulli.us, ivecera@...hat.com,
        f.fainelli@...il.com, andrew@...n.ch, Woojung.Huh@...rochip.com,
        stephen@...workplumber.org, mlxsw@...lanox.com
Subject: Re: [PATCH net-next 07/11] net: dsa: Remove support for bypass bridge
 port attributes/vlan set



On 07/18/2017 08:40 PM, Vivien Didelot wrote:
> Hi Arkadi,
> 
> Arkadi Sharshevsky <arkadis@...lanox.com> writes:
> 
>> The bridge port attributes/vlan for DSA devices should be set only
>> from bridge code. Furthermore, The vlans are synced totally with the
>> bridge so there is no need for special dump support.
>>
>> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>
>> ---
>>  drivers/net/dsa/b53/b53_common.c       | 44 --------------------------
>>  drivers/net/dsa/b53/b53_priv.h         |  3 --
>>  drivers/net/dsa/bcm_sf2.c              |  1 -
>>  drivers/net/dsa/dsa_loop.c             | 38 -----------------------
>>  drivers/net/dsa/microchip/ksz_common.c | 41 -------------------------
>>  drivers/net/dsa/mv88e6xxx/chip.c       | 56 ----------------------------------
>>  include/net/dsa.h                      |  4 ---
>>  net/dsa/dsa_priv.h                     |  4 ---
>>  net/dsa/port.c                         | 12 --------
>>  net/dsa/slave.c                        |  6 ----
> 
> Regarding this massive deletion, can you please split it in two patches,
> one deleting first the DSA core usage of .port_vlan_dump, i.e. in:
> 
>     net/dsa/dsa_priv.h
>     net/dsa/port.c
>     net/dsa/slave.c
> 
> Then a second patch which deletes the .port_vlan_dump implementations?
> 
> This may sound useless but it will actually make it easy for us to
> restore the VLAN dump support in drivers once we introduce an
> alternative way to query the hardware.
> 
> 
> Thanks,
> 
>         Vivien
> 

Yeah, no problem. But doesn't it make more sense to remove it first from
the drivers and then from core? If it will be removed from core first it
will leave unused code behind in the driver. Furthermore, it is
symmetric with the code adding. You first add the core implementation
and then only the drivers.