netdev - Re: [patch net-next 01/17] net: core: Make the FIB notification chain generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50e59e23-cc6e-2e75-ddb8-9b8b5afc847d@gmail.com>
Date:   Wed, 19 Jul 2017 08:11:56 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        kafai@...com, hannes@...essinduktion.org, yoshfuji@...ux-ipv6.org,
        edumazet@...gle.com, yanhaishuang@...s.chinamobile.com
Subject: Re: [patch net-next 01/17] net: core: Make the FIB notification chain
 generic

On 7/19/17 1:02 AM, Jiri Pirko wrote:
> +struct fib_notifier_ops *
> +fib_notifier_ops_register(const struct fib_notifier_ops *tmpl, struct net *net)
> +{
> +	struct fib_notifier_ops *ops;
> +	int err;
> +
> +	ops = kmemdup(tmpl, sizeof(*ops), GFP_KERNEL);

why allocate memory to copy the ops?