netdev - Re: [PATCH] net: ethernet: ti: cpsw: Push the request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a5cdde6-5898-8f8c-5c56-d47fa9513958@ti.com>
Date:   Thu, 20 Jul 2017 17:44:51 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     David Miller <davem@...emloft.net>
CC:     <j-keerthy@...com>, <linux-omap@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <johan@...nel.org>, <ivan.khoronzhuk@...aro.org>,
        <t-kristo@...com>, <nsekhar@...com>
Subject: Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to
 the end of probe



On 07/20/2017 05:28 PM, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@...com>
> Date: Thu, 20 Jul 2017 11:08:09 -0500
> 
>> In general patch looks good to me, but it's really unexpected to
>> receive IRQs while CPSW is probing ;(
> 
> This is a poor expectation.
> 
> Boot loaders and other entities can leave the device in any state
> whatsoever.
> 
> Furthermore, enabling an IRQ whose handler cannot properly execute
> without crashing is wrong fundamentally.  All data structures and
> state must be set up properly before the IRQ is requested.
> 
> Therefore this patch is correct and I will apply it.
> 

Thanks. Agree (it just has never triggered before, so I meant - unexpected
 from current driver code point of view ;().
And I'm just worry that it might not be enough :(, especially for am335x.

-- 
regards,
-grygorii