netdev - Re: [PATCH v2 1/1] iroute2: Add support for GRE ignore-df knob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170720084235.691873e0@xeon-e3>
Date:   Thu, 20 Jul 2017 08:42:35 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     "Philip Prindeville" <philipp@...fish-solutions.com>
Cc:     netdev@...r.kernel.org, Michele Lucini <mlucini@...earea.com.au>
Subject: Re: [PATCH v2 1/1] iroute2: Add support for GRE ignore-df knob

On Wed, 19 Jul 2017 23:19:33 -0600
"Philip Prindeville" <philipp@...fish-solutions.com> wrote:

> From: Philip Prindeville <philipp@...fish-solutions.com>
> 
> In the presence of firewalls which improperly block ICMP Unreachable
> (including Fragmentation Required) messages, Path MTU Discovery is
> prevented from working.
> 
> The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit.
> 
> Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Philip Prindeville <philipp@...fish-solutions.com>
> ---
>  doc/ip-cref.tex      |  7 +++++++
>  ip/link_gre.c        | 16 ++++++++++++++++
>  man/man8/ip-tunnel.8 |  9 +++++++++
>  3 files changed, 32 insertions(+)
> 

Please fix Subject line and the following minor checkpatch warnings and resubmit


WARNING: line over 80 characters
#109: FILE: ip/link_gre.c:170:
+			ignore_df = !!rta_getattr_u8(greinfo[IFLA_GRE_IGNORE_DF]);

WARNING: Block comments use a trailing */ on a separate line
#121: FILE: ip/link_gre.c:322:
+			// only the lsb is significant, use 2 for presence */

total: 0 errors, 2 warnings, 86 lines checked