netdev - Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170719.222516.1490852598794069450.davem@davemloft.net>
Date:   Wed, 19 Jul 2017 22:25:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jqiaoulk@...il.com
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

From: "Jianming.qiao" <jqiaoulk@...il.com>
Date: Wed, 19 Jul 2017 01:18:40 +0100

> Signed-off-by: Jianming.qiao <kiki-good@...mail.com>

Supporting both deprecated .ndo_get_stats and 64-bit .ndo_get_stats64
at the same time makes no sense.

.ndo_get_stats will never be called if .ndo_get_stats64 is non-NULL

The lack of a commit log message, explaining in detail, why you are
doing this and why you are doing it this way, concerns me as well.

This submission so far has been a bit of a mess.  You don't
communicate enough, your commit message is empty, and therefore we
have no idea why you are doing things, and in particular the reasons
for your decisions.

I'm not applying this, sorry.