netdev - Re: [PATCH v2] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170720172521.3fd57f26@xeon-e3>
Date:   Thu, 20 Jul 2017 17:25:21 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     Phil Sutter <phil@....cc>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] netns: avoid directory traversal (was: ip netns:
 Make sure netns name is sane)

On Thu, 20 Jul 2017 00:36:32 +0200
Matteo Croce <mcroce@...hat.com> wrote:

> v2: reword commit message
> 
> ip netns keeps track of created namespaces with bind mounts named
> /var/run/netns/<namespace>. No input sanitization is done, allowing creation and
> deletion of files relatives to /var/run/netns or, if the path is non existent or
> invalid, allows to create "untracked" namespaces (invisible to the tool).
> 
> This commit denies creation or deletion of namespaces with names contaning
> "/" or matching exactly "." or "..".
> 
> Signed-off-by: Matteo Croce <mcroce@...hat.com>

Applied. I manually edited the commit description to remove the (was...)
thanks Matteo.