netdev - Re: [PATCH net-next 1/3] bluetooth: 6lowpan dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9F800AAB-D2D1-4131-A6CD-01B16CAEF78D@holtmann.org>
Date:   Sat, 22 Jul 2017 08:42:37 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>, kbuild-all@...org,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        "David S. Miller" <davem@...emloft.net>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        netdev@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH net-next 1/3] bluetooth: 6lowpan dev_close never returns
 error

Hi Stephen,

> [auto build test WARNING on net-next/master]
> 
> url:    https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-dev_close-void/20170720-090123
> config: x86_64-randconfig-a0-07211734 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
>        # save the attached .config to linux build tree
>        make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
>   net/bluetooth/6lowpan.c: In function 'ifdown':
>>> net/bluetooth/6lowpan.c:621: warning: unused variable 'err'
> 
> vim +/err +621 net/bluetooth/6lowpan.c
> 
> 18722c24 Jukka Rissanen    2013-12-11  618  
> 7f118253 Jukka Rissanen    2014-06-18  619  static void ifdown(struct net_device *netdev)
> 7f118253 Jukka Rissanen    2014-06-18  620  {
> 7f118253 Jukka Rissanen    2014-06-18 @621  	int err;
> 7f118253 Jukka Rissanen    2014-06-18  622  
> 7f118253 Jukka Rissanen    2014-06-18  623  	rtnl_lock();
> ca74f73e Stephen Hemminger 2017-07-18  624  	dev_close(netdev);
> 7f118253 Jukka Rissanen    2014-06-18  625  	rtnl_unlock();
> 7f118253 Jukka Rissanen    2014-06-18  626  }
> 7f118253 Jukka Rissanen    2014-06-18  627  
> 
> :::::: The code at line 621 was first introduced by commit
> :::::: 7f118253820fc3ad38659485adb3ebdfe64820e1 Bluetooth: 6LoWPAN: Remove network devices when unloading
> 
> :::::: TO: Jukka Rissanen <jukka.rissanen@...ux.intel.com>
> :::::: CC: Marcel Holtmann <marcel@...tmann.org>

are you going to send a fix for this?

Regards

Marcel