netdev - Re: [PATCH iproute2 master 1/2] bpf: improve error reporting around tail calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5973078D.4080905@iogearbox.net>
Date:   Sat, 22 Jul 2017 10:06:37 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     ast@...com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 master 1/2] bpf: improve error reporting around
 tail calls

On 07/22/2017 01:28 AM, Stephen Hemminger wrote:
> On Fri, 21 Jul 2017 21:13:06 +0200
> Daniel Borkmann <daniel@...earbox.net> wrote:
>
>> Currently, it's still quite hard to figure out if a prog passed the
>> verifier, but later gets rejected due to different tail call ownership.
>> Figure out whether that is the case and provide appropriate error
>> messages to the user.
>>
>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>
> Sorry, dead code. Please fix and resubmit.
>
> bpf.c:356:12: warning: ‘bpf_derive_prog_from_fdinfo’ defined but not used [-Wunused-function]
>   static int bpf_derive_prog_from_fdinfo(int fd, struct bpf_prog_data *prog)

Yeah, v2 coming later today. I didn't compile with !HAVE_ELF,
where it's not in use indeed. Thanks!