netdev - Re: [PATCH net-next v3 1/1] geneve: add rtnl changelink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_Dbhs1PTqvAtPNdKWi9_rRF16zVsf1iOnQzn0-HYEaK5Q@mail.gmail.com>
Date:   Sun, 23 Jul 2017 10:14:46 -0700
From:   Pravin Shelar <pshelar@....org>
To:     Girish Moodalbail <girish.moodalbail@...cle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 1/1] geneve: add rtnl changelink support

On Thu, Jul 20, 2017 at 10:44 PM, Girish Moodalbail
<girish.moodalbail@...cle.com> wrote:
> This patch adds changelink rtnl operation support for geneve devices
> and the code changes involve:
>
>   - added geneve_quiesce() which quiesces the geneve device data path
>     for both TX and RX. This lets us perform the changelink operation
>     atomically w.r.t data path. Also added geneve_unquiesce() to
>     reverse the operation of geneve_quiesce().
>
>   - refactor geneve_newlink into geneve_nl2info to be used by both
>     geneve_newlink and geneve_changelink
>
>   - geneve_nl2info takes a changelink boolean argument to isolate
>     changelink checks.
>
>   - Allow changing only a few attributes (ttl, tos, and remote tunnel
>     endpoint IP address (within the same address family)):
>     - return -EOPNOTSUPP for attributes that cannot be changed for
>       now. Incremental patches can make the non-supported one
>       available in the future if needed.
>
> Signed-off-by: Girish Moodalbail <girish.moodalbail@...cle.com>
> ---
> v2 -> v3:
>    - removed the use of inline for new functions in my patch
>    - removed an extra check for socket in the datapath and instead
>      I am piggybacking on an already existing check
>    - added more comments to quiesce/unquiesce functions
>
> v1 -> v2:
>    - added geneve_quiesce() and geneve_unquiesce() functions to
>      perform the changelink operation atomically w.r.t data path

Thanks for working on it.

Acked-by: Pravin B Shelar <pshelar@....org>