netdev - Re: [patch net-next] mlxsw: spectrum_router: Fix build when IPv6 isn't enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6038dc49-5cd9-6169-8193-b473024c168a@gmail.com>
Date:   Mon, 24 Jul 2017 18:35:36 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net-next] mlxsw: spectrum_router: Fix build when IPv6
 isn't enabled

On 7/24/17 1:56 AM, Jiri Pirko wrote:
> @@ -949,9 +950,13 @@ mlxsw_sp_router_neighs_update_interval_init(struct mlxsw_sp *mlxsw_sp)
>  {
>  	unsigned long interval;
>  
> +#if IS_ENABLED(CONFIG_IPV6)
>  	interval = min_t(unsigned long,
>  			 NEIGH_VAR(&arp_tbl.parms, DELAY_PROBE_TIME),
>  			 NEIGH_VAR(&nd_tbl.parms, DELAY_PROBE_TIME));
> +#else
> +	interval = NEIGH_VAR(&arp_tbl.parms, DELAY_PROBE_TIME);
> +#endif
>  	mlxsw_sp->router->neighs_update.interval = jiffies_to_msecs(interval);
>  }
>  

arp and ndisc should have accessors for those rather than exporting the
tables to drivers.