netdev - Re: [PATCH net-next] nfp: set config bit (ifup/ifdown) on netdev open/close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170725.122958.2257952323982979614.davem@davemloft.net>
Date:   Tue, 25 Jul 2017 12:29:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        dirk.vandermerwe@...ronome.com
Subject: Re: [PATCH net-next] nfp: set config bit (ifup/ifdown) on netdev
 open/close

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Tue, 25 Jul 2017 00:51:08 -0700

> From: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> 
> When a netdev (PF netdev or representor) is opened or closed, set the
> physical port config bit appropriately - which powers UP/DOWN the PHY
> module for the physical interface.
> 
> The PHY is powered first in the HW/FW configuration step when opening
> the netdev and again last in the HW/FW configuration step when closing
> the netdev.
> 
> This is only applicable when there is a physical port associated with
> the netdev and if the NSP support this. Otherwise we silently ignore
> this step.
> 
> The 'nfp_eth_set_configured' can actually return positive values -
> updated the function documentation appropriately.
> 
> Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks Jakub.