netdev - Re: [PATCH] net: phy: Log only PHY state transitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170725.123303.483987159585881971.davem@davemloft.net>
Date:   Tue, 25 Jul 2017 12:33:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marc_gonzalez@...madesigns.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        slash.tmp@...e.fr
Subject: Re: [PATCH] net: phy: Log only PHY state transitions

From: Marc Gonzalez <marc_gonzalez@...madesigns.com>
Date: Tue, 25 Jul 2017 11:31:46 +0200

> In the current code, old and new PHY states are always logged.
> From now on, log only PHY state transitions.
> 
> Signed-off-by: Marc Gonzalez <marc_gonzalez@...madesigns.com>
> ---
>  drivers/net/phy/phy.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index d0626bf5c540..6bb764e716fc 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -1226,7 +1226,8 @@ void phy_state_machine(struct work_struct *work)
>  	if (err < 0)
>  		phy_error(phydev);
>  
> -	phydev_dbg(phydev, "PHY state change %s -> %s\n",
> +	if (old_state != phydev->state)
> +		phydev_dbg(phydev, "PHY state change %s -> %s\n",
>  		   phy_state_to_str(old_state),
>  		   phy_state_to_str(phydev->state));

Something is not kosher with this indentation at all.