netdev - Re: [PATCH] qtfnmac: Tidy up DMA mask setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170725220050.eksg3j53lemrhgdd@bars>
Date:   Wed, 26 Jul 2017 01:00:52 +0300
From:   Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>
To:     Robin Murphy <robin.murphy@....com>
Cc:     imitsyanko@...ntenna.com, avinashp@...ntenna.com,
        smatyukevich@...ntenna.com, kvalo@...eaurora.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qtfnmac: Tidy up DMA mask setting

> As the only caller of dma_supported() outside of DMA API internals, the
> qtfnmac driver stands out and invites scrutiny. Thankfully, it's not
> being used for evil, but it is entirely redundant, since it open-codes a
> check that the DMA mask setting functions are going to perform anyway.
> In fact, the whole qtnf_pcie_init_dma_mask() function is nothing more
> than a rather long-winded implementation of dma_set_mask_and_coherent(),
> so let's just use that directly.
> 
> Signed-off-by: Robin Murphy <robin.murphy@....com>


Nice, thanks you !

Acked-by: Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>