netdev - Re: [PATCH net-next v11 4/4] net sched actions: add time filter for action dumping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdd4e9f8-7d64-813b-fd6c-147d0bc3c0af@mojatatu.com>
Date:   Tue, 25 Jul 2017 07:27:03 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com, dsahern@...il.com,
        eric.dumazet@...il.com, mrv@...atatu.com,
        simon.horman@...ronome.com, alex.aring@...il.com
Subject: Re: [PATCH net-next v11 4/4] net sched actions: add time filter for
 action dumping

On 17-07-24 07:34 AM, Jiri Pirko wrote:
> Mon, Jul 24, 2017 at 03:35:46AM CEST, jhs@...atatu.com wrote:
>> From: Jamal Hadi Salim <jhs@...atatu.com>

> 
>> @@ -128,6 +129,11 @@ static int tcf_dump_walker(struct tcf_hashinfo *hinfo, struct sk_buff *skb,
>> 			if (index < s_i)
>> 				continue;
>>
>> +			if (jiffy_since &&
>> +			    time_after(jiffy_since,
>> +				       (unsigned long)p->tcfa_tm.lastuse))
> 
> You don't need to check jiffy_since==0. Also, nicer  ^^ this with a space :)
> 

Assuming that time_after() would work fine for jiffy_since being zero,
but:
wouldnt it be more efficient to just not call time_after() altogether?

> Other than this, looks fine.

Ok, please no more changes - I am exhausted ;-> So speak for this
update or send patches afterwards if you dont like something.

cheers,
jamal