netdev - RE: [PATCH] netns: more input validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD003FE88@AcuExch.aculab.com>
Date:   Tue, 25 Jul 2017 13:47:25 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Matteo Croce' <mcroce@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Stephen Hemminger <stephen@...workplumber.org>
Subject: RE: [PATCH] netns: more input validation

From: Matteo Croce
> Sent: 25 July 2017 14:31
> ip netns accepts invalid input as namespace name like an empty string or a
> string longer than the maximum file name length.
> Check that the netns name is not empty and less than or equal to NAME_MAX.
> 
> Signed-off-by: Matteo Croce <mcroce@...hat.com>
> ---
>  ip/ipnetns.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ip/ipnetns.c b/ip/ipnetns.c
> index 42549944..198e9de8 100644
> --- a/ip/ipnetns.c
> +++ b/ip/ipnetns.c
> @@ -768,7 +768,8 @@ static int netns_monitor(int argc, char **argv)
> 
>  static int invalid_name(const char *name)
>  {
> -	return strchr(name, '/') || !strcmp(name, ".") || !strcmp(name, "..");
> +	return !*name || strlen(name) > NAME_MAX ||
> +		strchr(name, '/') || !strcmp(name, ".") || !strcmp(name, "..");

Think I'd check:
	!name[0] || !memchr(name, 0, NAME_MAX) || strchr(name, '/') ||
		(name[0] == '.' && (!name[1] || (name[1] == '.' && !name[2])))

	David