netdev - Re: [PATCH net 1/1] Revert "netvsc: optimize calculation of number of slots"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170725.212723.757677468799150125.davem@davemloft.net>
Date:   Tue, 25 Jul 2017 21:27:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        devel@...uxdriverproject.org, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/1] Revert "netvsc: optimize calculation of number
 of slots"

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Mon, 24 Jul 2017 21:03:19 -0700

> The logic for computing page buffer scatter does not take into
> account the impact of compound pages. Therefore the optimization
> to compute number of slots was incorrect and could cause stack
> corruption a skb was sent with lots of fragments from huge pages.
> 
> This reverts commit 60b86665af0dfbeebda8aae43f0ba451cd2dcfe5.
> 
> Fixes: 60b86665af0d ("netvsc: optimize calculation of number of slots")
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>

Applied.