netdev - Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170726223327.GG7966@lunn.ch>
Date:   Thu, 27 Jul 2017 00:33:27 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Aviad Krawczyk <aviad.krawczyk@...wei.com>
Cc:     Joe Perches <joe@...ches.com>, davem@...emloft.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bc.y@...wei.com, victor.gissin@...wei.com, zhaochen6@...wei.com,
        tony.qu@...wei.com
Subject: Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote:
> Hi Joe,
> 
> I tried to be consistent with the comments before, that requested
> that we will use dev_err exclude some special cases for use netif.
> 
> We will replace the dev_err(&netdev->dev,.. to netdev_err in the
> next fix.

netdev_err() should be used when possible. You just have to be careful
in the probe() function, before netdev exists and you get "(NULL
net_device):" or before it is registered and you get "(unnamed
net_device)" instead of "eth42" etc.

	      Andrew