netdev - Re: [PATCH] netpoll: Fix device name check in netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170726.170211.1958869072074713467.davem@davemloft.net>
Date:   Wed, 26 Jul 2017 17:02:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mka@...omium.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        dianders@...omium.org
Subject: Re: [PATCH] netpoll: Fix device name check in netpoll_setup()

From: Matthias Kaehlcke <mka@...omium.org>
Date: Tue, 25 Jul 2017 11:36:25 -0700

> Apparently netpoll_setup() assumes that netpoll.dev_name is a pointer
> when checking if the device name is set:
> 
> if (np->dev_name) {
>   ...
> 
> However the field is a character array, therefore the condition always
> yields true. Check instead whether the first byte of the array has a
> non-zero value.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Applied, thanks a lot.