[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87fudgqz4w.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date: Fri, 28 Jul 2017 12:55:59 -0400
From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To: Egil Hjelmeland <privat@...l-hjelmeland.no>, andrew@...n.ch,
f.fainelli@...il.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly
Hi Egil,
Egil Hjelmeland <privat@...l-hjelmeland.no> writes:
>>> +const struct lan9303_phy_ops lan9303_indirect_phy_ops = {
>>> + .phy_read = lan9303_indirect_phy_read,
>>> + .phy_write = lan9303_indirect_phy_write,
>>> +};
>>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops);
>>
>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?
>
> I have no opinion. I just used the same variant as the other EXPORTS
> in the file.
If there is no concern from others about this, LGTM too:
Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Thanks,
Vivien
Powered by blists - more mailing lists