netdev - Re: [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170728.185208.821362205555741040.davem@davemloft.net>
Date:   Fri, 28 Jul 2017 18:52:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natale.patriciello@...il.com
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, netdev@...r.kernel.org, ahmed.said@...roma2.it,
        zampognaro@....uniroma2.it, roseti@....uniroma2.it
Subject: Re: [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave

From: Natale Patriciello <natale.patriciello@...il.com>
Date: Fri, 28 Jul 2017 21:59:19 +0200

> +static __always_inline bool test_flag(u8 value, const u8 *flags)

Never, ever, declare functions as inline in foo.c files.

Always let the compiler decide.  No matter how brilliant you think
you are, it always knows better.

And when it doesn't, that's a bug that should be fixed instead of
worked around in our code.

Thanks.