netdev - Re: [PATCH net-next] bnxt_re: add MAY_USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170729.141825.1080468412995768419.davem@davemloft.net>
Date:   Sat, 29 Jul 2017 14:18:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sathya.perla@...adcom.com
Cc:     netdev@...r.kernel.org, selvin.xavier@...adcom.com,
        devesh.sharma@...adcom.com, arnd@...db.de,
        michael.chan@...adcom.com
Subject: Re: [PATCH net-next] bnxt_re: add MAY_USE_DEVLINK dependency

From: Sathya Perla <sathya.perla@...adcom.com>
Date: Thu, 27 Jul 2017 06:29:51 -0400

> bnxt_en depends on MAY_USE_DEVLINK; this is used to force bnxt_en
> to be =m when DEVLINK is =m.
> 
> Now, bnxt_re selects bnxt_en. Unless bnxt_re also explicitly calls
> out dependency on MAY_USE_DEVLINK, Kconfig does not force bnxt_re
> to be =m when DEVLINK is =m, causing the following error:
> 
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function
> `bnxt_dl_register':
> bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc'
> bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink_register'
> bnxt_vfr.c:(.text+0x14e0): undefined reference to `devlink_free'
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function
> `bnxt_dl_unregister':
> bnxt_vfr.c:(.text+0x1534): undefined reference to `devlink_unregister'
> bnxt_vfr.c:(.text+0x153c): undefined reference to `devlink_free'
> 
> Fix this by adding MAY_USE_DEVLINK dependency in bnxt_re.
> 
> Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors")
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Sathya Perla <sathya.perla@...adcom.com>

Applied.