netdev - Re: [patch net-next 00/20] net: sched: summer cleanup part 1, mainly in exts area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170731.143530.1446378598611188601.davem@davemloft.net>
Date:   Mon, 31 Jul 2017 14:35:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        daniel@...earbox.net, mlxsw@...lanox.com
Subject: Re: [patch net-next 00/20] net: sched: summer cleanup part 1,
 mainly in exts area

From: Jiri Pirko <jiri@...nulli.us>
Date: Fri, 28 Jul 2017 16:40:22 +0200

> From: Jiri Pirko <jiri@...lanox.com>
> 
> This patchset is one of the couple cleanup patchsets I have in queue.
> The motivation aside the obvious need to "make things nicer" is also
> to prepare for shared filter blocks introduction. That requires tp->q
> removal, and therefore removal of all tp->q users.
> 
> Patch 1 is just some small thing I spotted on the way
> Patch 2 removes one user of tp->q, namely tcf_em_tree_change
> Patches 3-8 do preparations for exts->nr_actions removal
> Patch 9 does the conversion of action array into rcuized list. This is also
>         one tp->q user removal.
> Patches 10-11 do simple renames of functions in cls*
> The rest of the patches remove unnecessary calls of tcf_exts_change helper.
> 
> Tested by tools/testing/selftests/tc-testing

It looks like patch #9 needs some changes, or at least more explanation
in the commit log message, based upon Cong's feedback.