netdev - Re: [PATCH net-next 0/7] net: bcmgenet: utilize MDIO unimac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170731.144119.1261443747903049163.davem@davemloft.net>
Date:   Mon, 31 Jul 2017 14:41:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, opendmb@...il.com, jaedon.shin@...il.com,
        pgynther@...gle.com
Subject: Re: [PATCH net-next 0/7] net: bcmgenet: utilize MDIO unimac driver

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 31 Jul 2017 12:04:21 -0700

> Hi all,
> 
> This patch series migrates the Broadcom GENET driver to use the mdio-bcm-unimac
> driver. This MDIO HW is the same as the one GENET internally embedds, yet for
> historical reasons the two drivers lived their own lives. Because of the GENET
> interrupt situation, we let it specify how it wants to signal MDIO operations
> completion using its driver-private waitqueue.
> 
> The diffstat is not super impressive, but it's still negative! This would
> make it easier in the future to absorb possible workarounds/bugs/features
> within the same location.
> 
> This was tested on BCM7260 (GENETv5, single instance), BCM7439 (GENETv4, triple
> instance) and BCM7445 (bcm_sf2 + mdio-bcm-unimac).
> 
> We also now have a nice /proc/iomem output:
> 
> f0b00000-f0b0fc4b : /rdb/ethernet@...00000
>   f0b00e14-f0b00e1c : unimac-mdio.0
> f0b20000-f0b2fc4b : /rdb/ethernet@...20000
>   f0b20e14-f0b20e1c : unimac-mdio.1
> f0b40000-f0b4fc4b : /rdb/ethernet@...40000
>   f0b40e14-f0b40e1c : unimac-mdio.2

I love cleanups like this... even if the diffstat breaks even :-)

Applied, thanks.