netdev - Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170801074931.34102262@xeon-e3>
Date:   Tue, 1 Aug 2017 07:49:31 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     mohamedalrshah <mohamed.asnd@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        mohamed.a.alrshah@...e.org
Subject: Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and
 Makefile to configure the kernel for this new module to configure the
 kernel for this new module.

On Tue,  1 Aug 2017 17:50:05 +0800
mohamedalrshah <mohamed.asnd@...il.com> wrote:

> From: Mohamed Alrshah <mohamed.asnd@...il.com>
> 

Please add more background on Agile-SD in the email commit message.


> +static struct tcp_congestion_ops agilesdtcp __read_mostly = {
> +	.init		= agilesdtcp_init,
> +	.ssthresh	= agilesdtcp_recalc_ssthresh, 	//REQUIRED
> +	.cong_avoid	= agilesdtcp_cong_avoid, 	//REQUIRED
> +	.set_state	= agilesdtcp_state,
> +	.undo_cwnd	= agilesdtcp_undo_cwnd,
> +	.pkts_acked	= agilesdtcp_acked,
> +	.owner		= THIS_MODULE,
> +	.name		= "agilesd", 			//REQUIRED
> +	//.min_cwnd	= agilesdtcp_min_cwnd, 		//NOT REQUIRED
> +};

Your code must match kernel coding style. See Documentation for more
info and use the checkpatch.pl checking script.