[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0db350e1-1df5-5a3a-095e-183db15d09a0@gmail.com>
Date: Tue, 1 Aug 2017 09:32:38 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Arnd Bergmann <arnd@...db.de>,
"David S. Miller" <davem@...emloft.net>
Cc: Michael Chan <michael.chan@...adcom.com>,
Sathya Perla <sathya.perla@...adcom.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency
On 08/01/2017 04:50 AM, Arnd Bergmann wrote:
> The last patch added the dependency on 'OF && HAS_IOMEM' but left
> COMPILE_TEST as an alternative, which kind of defeats the purpose
> of adding the dependency, we still get randconfig build warnings:
>
> warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_BUS && HAS_IOMEM && OF_MDIO)
>
> For compile-testing purposes, we don't really need this anyway,
> as CONFIG_OF can be enabled on all architectures, and HAS_IOMEM
> is present on all architectures we do meaningful compile-testing on
> (the exception being arch/um).
>
> This makes both OF and HAS_IOMEM hard dependencies.
>
> Fixes: 5af74bb4fcf8 ("net: bcmgenet: Add dependency on HAS_IOMEM && OF")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
Thanks!
--
Florian
Powered by blists - more mailing lists