netdev - Re: [PATCH net-next v2 09/11] net: dsa: remove PHY device argument from .set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170801210626.GQ23157@lunn.ch>
Date:   Tue, 1 Aug 2017 23:06:26 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Crispin <john@...ozen.org>
Subject: Re: [PATCH net-next v2 09/11] net: dsa: remove PHY device argument
 from .set_eee

On Tue, Aug 01, 2017 at 04:32:39PM -0400, Vivien Didelot wrote:
> The DSA switch operations for EEE are only meant to configure a port's
> MAC EEE settings. The port's PHY EEE settings are accessed by the DSA
> layer and must be made available via a proper PHY driver.
> 
> In order to reduce this confusion, remove the phy_device argument from
> the .set_eee operation.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew