netdev - Re: [PATCH net] mcs7780: Silence uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170801104516.7n2uwq5wv64qaq4d@mwanda>
Date:   Tue, 1 Aug 2017 13:45:17 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     samuel@...tiz.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] mcs7780: Silence uninitialized variable warning

On Mon, Jul 31, 2017 at 10:37:16AM -0700, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@...cle.com>
> Date: Mon, 31 Jul 2017 10:41:40 +0300
> 
> > On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote:
> >> From: Dan Carpenter <dan.carpenter@...cle.com>
> >> Date: Fri, 28 Jul 2017 17:45:11 +0300
> >> 
> >> > -	__u16 rval;
> >> > +	__u16 rval = -1;
> >> 
> >> Fixing a bogus warning by assigning a signed constant to an
> >> unsigned variable doesn't really make me all that happy.
> >> 
> >> I don't think I'll apply this, sorry.
> > 
> > There's no guarantee that small kmallocs will always succeed in future
> > kernels so it's not *totally* bogus.
> 
> Perhaps the burdon of initializing the value belongs in
> mcs_get_reg(), and you can set it properly to 0xffff
> instead of -1.
> 
> Ok?

Sure.  I will resend.

thanks,
dan carpenter