netdev - Re: [PATCH net 6/7] netvsc: Initialize 64-bit stats seqcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2017 19:42:42 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        open list <linux-kernel@...r.kernel.org>, edumazet@...gle.com,
        "open list:Hyper-V CORE AND DRIVERS" <devel@...uxdriverproject.org>,
        davem@...emloft.net
Subject: Re: [PATCH net 6/7] netvsc: Initialize 64-bit stats seqcount

On Tue,  1 Aug 2017 12:11:12 -0700
Florian Fainelli <f.fainelli@...il.com> wrote:

> On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a
> lockdep splat indicating this seqcount is not correctly initialized, fix
> that. In commit 6c80f3fc2398 ("netvsc: report per-channel stats in
> ethtool statistics") netdev_alloc_pcpu_stats() was removed in favor of
> open-coding the 64-bits statistics, except that u64_stats_init() was
> missed.
> 
> Fixes: 6c80f3fc2398 ("netvsc: report per-channel stats in ethtool statistics")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/net/hyperv/netvsc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index 0a9167dd72fb..96f90c75d1b7 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -1302,6 +1302,8 @@ int netvsc_device_add(struct hv_device *device,
>  		struct netvsc_channel *nvchan = &net_device->chan_table[i];
>  
>  		nvchan->channel = device->channel;
> +		u64_stats_init(&nvchan->tx_stats.syncp);
> +		u64_stats_init(&nvchan->rx_stats.syncp);
>  	}
>  
>  	/* Enable NAPI handler before init callbacks */


Looks good, thanks. 32 bit guests are still supported but rarely tested.

Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>