netdev - Re: [PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170802195813.GB47485@apz-mbp.dhcp.thefacebook.com>
Date:   Wed, 2 Aug 2017 12:58:13 -0700
From:   Dave Watson <davejwatson@...com>
To:     Tom Herbert <tom@...ntonium.net>
CC:     <netdev@...r.kernel.org>, <rohit@...ntonium.net>
Subject: Re: [PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets
 ULP

On 08/01/17 08:18 PM, Tom Herbert wrote:
>  
> -static int tls_init(struct sock *sk)
> +static int tls_init(struct sock *sk, char __user *optval, int len)
>  {
> -	struct inet_connection_sock *icsk = inet_csk(sk);
>  	struct tls_context *ctx;
>  	int rc = 0;
>  
> @@ -450,7 +449,7 @@ static int tls_init(struct sock *sk)
>  		rc = -ENOMEM;
>  		goto out;
>  	}
> -	icsk->icsk_ulp_data = ctx;
> +	sk->sk_ulp_data = ctx;
>  	ctx->setsockopt = sk->sk_prot->setsockopt;
>  	ctx->getsockopt = sk->sk_prot->getsockopt;
>  	sk->sk_prot = &tls_base_prot;
> @@ -458,7 +457,7 @@ static int tls_init(struct sock *sk)
>  	return rc;
>  }

It looks like tls_init should be checking if this is a tcp socket now
also, and failing if not