netdev - Re: [PATCH net-next 2/4] sock: ULP infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201708021533.eau5MA08%fengguang.wu@intel.com>
Date:   Wed, 2 Aug 2017 15:52:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Tom Herbert <tom@...ntonium.net>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, rohit@...ntonium.net,
        davejwatson@...com, Tom Herbert <tom@...ntonium.net>
Subject: Re: [PATCH net-next 2/4] sock: ULP infrastructure

Hi Tom,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Tom-Herbert/ulp-Generalize-ULP-infrastructure/20170802-142035
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/net/sock.h:75:0,
                    from include/net/inet_sock.h:27,
                    from include/net/ip.h:30,
                    from drivers/net/ethernet/broadcom/cnic.c:37:
   include/net/ulp_sock.h:51:1: error: expected identifier or '(' before '{' token
    {
    ^
   include/net/ulp_sock.h:56:1: error: expected identifier or '(' before '{' token
    {
    ^
   include/net/ulp_sock.h:60:1: error: expected identifier or '(' before '{' token
    {
    ^
>> drivers/net/ethernet/broadcom/cnic.c:178:20: error: conflicting types for 'ulp_get'
    static inline void ulp_get(struct cnic_ulp_ops *ulp_ops)
                       ^~~~~~~
   In file included from include/net/sock.h:75:0,
                    from include/net/inet_sock.h:27,
                    from include/net/ip.h:30,
                    from drivers/net/ethernet/broadcom/cnic.c:37:
   include/net/ulp_sock.h:50:5: note: previous declaration of 'ulp_get' was here
    int ulp_get(struct sock *sk, char __user *optval, int *optlen);
        ^~~~~~~

vim +/ulp_get +178 drivers/net/ethernet/broadcom/cnic.c

a4636960 drivers/net/cnic.c Michael Chan 2009-06-08  177  
7fc1ece4 drivers/net/cnic.c Michael Chan 2009-08-14 @178  static inline void ulp_get(struct cnic_ulp_ops *ulp_ops)
7fc1ece4 drivers/net/cnic.c Michael Chan 2009-08-14  179  {
7fc1ece4 drivers/net/cnic.c Michael Chan 2009-08-14  180  	atomic_inc(&ulp_ops->ref_count);
7fc1ece4 drivers/net/cnic.c Michael Chan 2009-08-14  181  }
7fc1ece4 drivers/net/cnic.c Michael Chan 2009-08-14  182  

:::::: The code at line 178 was first introduced by commit
:::::: 7fc1ece40704b150477e548a7a98d285cc418790 cnic: Fix locking in init/exit calls.

:::::: TO: Michael Chan <mchan@...adcom.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (39621 bytes)