netdev - Re: [PATCH net] tcp: avoid setting cwnd to invalid ssthresh after cwnd reduction states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170803.093003.630342740216225722.davem@davemloft.net>
Date:   Thu, 03 Aug 2017 09:30:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ycheng@...gle.com
Cc:     netdev@...r.kernel.org, ncardwell@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net] tcp: avoid setting cwnd to invalid ssthresh after
 cwnd reduction states

From: Yuchung Cheng <ycheng@...gle.com>
Date: Wed, 2 Aug 2017 10:58:54 -0700

> On Wed, Aug 2, 2017 at 10:51 AM, David Miller <davem@...emloft.net> wrote:
>>
>> From: Yuchung Cheng <ycheng@...gle.com>
>> Date: Tue,  1 Aug 2017 13:22:32 -0700
>>
>> > If the sender switches the congestion control during ECN-triggered
>> > cwnd-reduction state (CA_CWR), upon exiting recovery cwnd is set to
>> > the ssthresh value calculated by the previous congestion control. If
>> > the previous congestion control is BBR that always keep ssthresh
>> > to TCP_INIFINITE_SSTHRESH, cwnd ends up being infinite. The safe
>> > step is to avoid assigning invalid ssthresh value when recovery ends.
>> >
>> > Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
>> > Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
>>
>> Applied, thanks.
>>
>> Is this a -stable candidate?
> 
> Yes it is. Thanks!

Great, queued up.