netdev - Re: [PATCH net] net: fix keepalive code vs TCP_FASTOPEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170803.093543.1047513143422057166.davem@davemloft.net>
Date:   Thu, 03 Aug 2017 09:35:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, weiwan@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net] net: fix keepalive code vs TCP_FASTOPEN_CONNECT

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 02 Aug 2017 23:10:46 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> syzkaller was able to trigger a divide by 0 in TCP stack [1]
> 
> Issue here is that keepalive timer needs to be updated to not attempt
> to send a probe if the connection setup was deferred using
> TCP_FASTOPEN_CONNECT socket option added in linux-4.11
...
> Fixes: 19f6d3f3c842 ("net/tcp-fastopen: Add new API support")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>

Applied and queued up for -stable, thanks!