netdev - Re: [PATCH net] ipv6: set rt6i_protocol properly in the route when it is installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170803.151059.789231468106619997.davem@davemloft.net>
Date:   Thu, 03 Aug 2017 15:10:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, grawity@...il.com, dsahern@...il.com
Subject: Re: [PATCH net] ipv6: set rt6i_protocol properly in the route when
 it is installed

From: Xin Long <lucien.xin@...il.com>
Date: Thu,  3 Aug 2017 14:13:46 +0800

> After commit c2ed1880fd61 ("net: ipv6: check route protocol when
> deleting routes"), ipv6 route checks rt protocol when trying to
> remove a rt entry.
> 
> It introduced a side effect causing 'ip -6 route flush cache' not
> to work well. When flushing caches with iproute, all route caches
> get dumped from kernel then removed one by one by sending DELROUTE
> requests to kernel for each cache.
> 
> The thing is iproute sends the request with the cache whose proto
> is set with RTPROT_REDIRECT by rt6_fill_node() when kernel dumps
> it. But in kernel the rt_cache protocol is still 0, which causes
> the cache not to be matched and removed.
> 
> So the real reason is rt6i_protocol in the route is not set when
> it is allocated. As David Ahern's suggestion, this patch is to
> set rt6i_protocol properly in the route when it is installed and
> remove the codes setting rtm_protocol according to rt6i_flags in
> rt6_fill_node.
> 
> This is also an improvement to keep rt6i_protocol consistent with
> rtm_protocol.
> 
> Fixes: c2ed1880fd61 ("net: ipv6: check route protocol when deleting routes")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Suggested-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.