netdev - Re: [PATCH v4] ss: Enclose IPv6 address in brackets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2017 15:54:21 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Florian Lehner <dev@...-flo.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v4] ss: Enclose IPv6 address in brackets

On Tue, 1 Aug 2017 18:54:33 +0200
Florian Lehner <dev@...-flo.net> wrote:

> -	if (a->family == AF_INET) {
> -		if (a->data[0] == 0) {
> +	if (a->data[0] == 0) {
>  			buf[0] = '*';
>  			buf[1] = 0;

This won't work right with IPv6 you need to look at the whole address being 0
not just a->data[0]