netdev - Re: [PATCH iproute2] netns: make /var/run/netns bind-mount recursive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170803160421.58eb0a4a@xeon-e3>
Date:   Thu, 3 Aug 2017 16:04:21 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Casey Callendrello <casey.callendrello@...eos.com>
Cc:     netdev@...r.kernel.org, "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH iproute2] netns: make /var/run/netns bind-mount
 recursive

On Tue,  1 Aug 2017 17:46:09 +0200
Casey Callendrello <casey.callendrello@...eos.com> wrote:

> When ip netns {add|delete} is first run, it bind-mounts /var/run/netns
> on top of itself, then marks it as shared. However, if there are already
> bind-mounts in the directory from other tools, these would not be
> propagated. Fix this by recursively bind-mounting.
> 
> Signed-off-by: Casey Callendrello <casey.callendrello@...eos.com>
> ---
>  ip/ipnetns.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Looks good, but I want a review by Eric to make sure this doesn't break other things.