netdev - Re: [PATCH v7 net-next] net: systemport: Support 64bit statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170803.164554.1116282475558581464.davem@davemloft.net>
Date:   Thu, 03 Aug 2017 16:45:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     stephen@...workplumber.org, jqiaoulk@...il.com,
        eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v7 net-next] net: systemport: Support 64bit statistics

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 3 Aug 2017 16:20:04 -0700

> On 08/03/2017 04:16 PM, Stephen Hemminger wrote:
>> On Fri,  4 Aug 2017 00:07:45 +0100
>> "Jianming.qiao" <jqiaoulk@...il.com> wrote:
>> 
>>>  static const struct bcm_sysport_stats bcm_sysport_gstrings_stats[] = {
>>>  	/* general stats */
>>> -	STAT_NETDEV(rx_packets),
>>> -	STAT_NETDEV(tx_packets),
>>> -	STAT_NETDEV(rx_bytes),
>>> -	STAT_NETDEV(tx_bytes),
>>> +	STAT_NETDEV64(rx_packets),
>>> +	STAT_NETDEV64(tx_packets),
>>> +	STAT_NETDEV64(rx_bytes),
>>> +	STAT_NETDEV64(tx_bytes),
>>>  	STAT_NETDEV(rx_errors),
>> 
>> Please don't duplicate regular statistics (ie netdev) into ethtool.
>> It is a needless duplication.
> 
> Agreed, but these are there already and this driver's ethtool::get_stats
> is an user ABI of some sort, is not it?

Agreed, they have to stay at this point.