netdev - Re: [PATCH 2/2 net-next] tcp: consolidate congestion control undo functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201708040913.8jTcyvVO%fengguang.wu@intel.com>
Date:   Fri, 4 Aug 2017 09:08:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yuchung Cheng <ycheng@...gle.com>
Cc:     kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
        ncardwell@...gle.com, unlcsewsun@...il.com,
        stephen@...workplumber.org, Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH 2/2 net-next] tcp: consolidate congestion control undo
 functions

Hi Yuchung,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yuchung-Cheng/tcp-fix-cwnd-undo-in-Reno-and-HTCP-congestion-controls/20170804-085255
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   net/ipv4/tcp_cdg.c: In function 'tcp_cdg_backoff':
>> net/ipv4/tcp_cdg.c:256:2: error: too many arguments to function 'tcp_enter_cwr'
     tcp_enter_cwr(sk, true);
     ^
   In file included from net/ipv4/tcp_cdg.c:32:0:
   include/net/tcp.h:1149:6: note: declared here
    void tcp_enter_cwr(struct sock *sk);
         ^
--
   net/ipv4/tcp_nv.c: In function 'tcpnv_recalc_ssthresh':
   net/ipv4/tcp_nv.c:178:16: warning: unused variable 'ca' [-Wunused-variable]
     struct tcpnv *ca = inet_csk_ca(sk);
                   ^
   net/ipv4/tcp_nv.c: At top level:
>> net/ipv4/tcp_nv.c:439:15: error: 'tcpnv_reno_undo_cwnd' undeclared here (not in a function)
     .undo_cwnd = tcpnv_reno_undo_cwnd,
                  ^

vim +/tcp_enter_cwr +256 net/ipv4/tcp_cdg.c

   239	
   240	static bool tcp_cdg_backoff(struct sock *sk, u32 grad)
   241	{
   242		struct cdg *ca = inet_csk_ca(sk);
   243		struct tcp_sock *tp = tcp_sk(sk);
   244	
   245		if (prandom_u32() <= nexp_u32(grad * backoff_factor))
   246			return false;
   247	
   248		if (use_ineff) {
   249			ca->backoff_cnt++;
   250			if (ca->backoff_cnt > use_ineff)
   251				return false;
   252		}
   253	
   254		ca->shadow_wnd = max(ca->shadow_wnd, tp->snd_cwnd);
   255		ca->state = CDG_BACKOFF;
 > 256		tcp_enter_cwr(sk, true);
   257		return true;
   258	}
   259	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50916 bytes)